On 3 August 2015 at 21:31, Andy Goth <[email protected]> wrote:
> Many times I've created files, modified existing files to reference
> them, tested, and committed, only to later discover I forgot to add the
> newly created files to the repository.
>
> After making this mistake, I know I'm supposed to move the bad commit to
> a hidden branch and try again.  Usually I don't bother, especially if
> there have been check-ins since the error was committed.  Instead I just
> add the omitted files as a new check-in.  However, this complicates bisect.
>
> In most of my projects I do a good job of maintaining the ignore-glob
> setting, so fossil extras gives an accurate list of files I either need
> to add to my check-in or add to ignore-glob.
>
> It occurs to me the whole problem can be avoided by having a
> check-extras setting which makes the commit command print a warning
> requiring confirmation to proceed if there are any extra files.  This
> setting would be off by default but can be turned on for projects that
> diligently maintain ignore-glob.  The prompt might offer an option to
> list the files, then (after the list is shown) ask if they all should be
> added.
>
> I usually run fossil extras along with fossil changes prior to doing
> commit.  If check-extras is turned on, I suggest having fossil changes
> go ahead and list the extra-but-not-added files, marking them EXTRA but
> not ADDED.  This way I can run one command to get a complete list of
> things pertinent to the next commit.

You mean that the same setting would apply to 'commit' and 'changes', right?

(In the case where '-m' is not given to 'commit', it could perhaps
list the extra files as
'EXTRA' in the currently displayed overview of files; I think that
would be hint enough
to the user.)

I would be very interested in a setting that makes 'fossil changes' also list
extra files. Checking for both 'extras' and 'changes' is an automatism here;
it's what I always want (never just just one but not the other).

To have that same setting apply to 'commit -m': I don't know. Sounds
like 2 different
settings to me. ('changes-also-list-extras' and
'commit-warn-about-extras' or so)

</EUR0.02>

MIchai
_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to