I noticed a minor bug in fossil. Observed on Windows 10 with all of:
1) fossil 1.35 and 1.36 (downloaded executables):
2) built from source (MSVC build, latest code as of 2016-12-11)
I am in the open checkout of a local (file) repository. I have added a
large number of files. Some have mixed line endings, so when I commit,
fossil warns me about them. At this point, I hit Ctrl-C rather than
a/c/y/n. About 10% of the time, I see one of the snippets of text below.
There's no data loss, but it's concerning. The rest of the time, I see
the "Abandoning commit..." message and nothing else, as expected.
SNIPPET 1
C:\Users\Ross\src>fossil commit -m "created"
./math/src/transforms.rs contains mixed line endings. Use --no-warnings
or the "crnl-glob" setting to disable this warning.
Commit anyhow (a=all/c=convert/y/N)?
*** I hit Ctrl-C here ***
Abandoning commit due to mixed line endings in ./math/src/transforms.rs
SQLITE_MISUSE: API call with invalid database connection pointer
SQLITE_MISUSE: misuse at line 138842 of [707875582f]
^C
C:\Users\Ross\src>
SNIPPET 2
C:\Users\Ross\src>fossil commit -m "created"
./Dictionaries/README.txt contains CR/NL line endings. Use --no-warnings
or the "crnl-glob" setting to disable this warning.
Commit anyhow (a=all/c=convert/y/N)?
*** I hit Ctrl-C here ***
Abandoning commit due to CR/NL line endings in ./Dictionaries/README.txt
SQLITE_IOERR: os_win.c:40211: (6)
winFileSize(C:\Users\Ross\repos\all.fossil-journal) - The handle is
invalid.
^C
C:\Users\Ross\src>
On two occasions, fossil has exited normally on the Ctrl-C, but the next
time I run it, I see:
SQLITE_NOTICE: recovered 9 pages from
C:\Users\Ross\AppData\Local\_fossil-journal
If it's hard to repro, I can do some detective work here, but I'd need
to know what *should* happen in this scenario. It seems like fossil
doesn't install a handler for Ctrl-C, so how should this scenario be
handled?
TIA
Ross
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
