The function file_wd_isdir() seems to have a number of bugs when used with symbolic links. This manifests on macOS in particular (where /tmp links to private/tmp – note that the link is relative), when temporary directories are created, e.g. for "fossil diff --checkin ...".

* Relative links are not properly followed. They are treated as being relative to the current directory, rather than the source of the symlink.
* Symlinks pointing to themselves will trigger infinite recursion.
* The db_allow_symlinks() logic should probably not apply to directories outside a checkout (such as /tmp).

                        Reimer Behrends
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to