Good morning,

When I compile Fossil revision [f21820f4] with Visual C++ 2010 I get
following warning:
import.c(1275) : warning C4715: 'svn_handle_symlinks' : not all control
paths return a value

Although, at line 1270 there is:
fossil_fatal("Too short symbolic link path");

which is a NORETURN function but the macro is only defined for gcc or clang
compilers.


Proposed patch add definition of NORETURN macro for msvc compiler and the
warning vanishes.


<http://fossil-scm.org/index.html/info/f21820f4abbeada7>
Index: src/config.h
==================================================================
--- src/config.h
+++ src/config.h
@@ -229,10 +229,12 @@
 /*
 ** A marker for functions that never return.
 */
 #if defined(__GNUC__) || defined(__clang__)
 # define NORETURN __attribute__((__noreturn__))
+#elif defined(_MSC_VER)
+# define NORETURN __declspec(noreturn)
 #else
 # define NORETURN
 #endif
 
 /*

_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to