On Fri, Jun 9, 2017 at 2:01 PM, Richard Hipp <d...@sqlite.org> wrote:

> I think there are many other examples where Fossil finds incorrect
> query parameters and reports an error in text, but still returns "200
> ok".  If returning a non-200 result codes on an error is important,
> then we have a lot of clean-up to do.
>
> Also, I'm not sure setting the result code to an error before a
> function that potentially errors-out, then resetting it back to 200
> afterwards, is the correct fix.
>

Perhaps name_to_typed_rid() should set it to 404 IF running in [non-json]
http mode? (For JSON, the API currently returns 200 everywhere and uses its
own error codes to report what went wrong. That behaviour is arguable but
consistent.)

-- 
----- stephan beal
http://wanderinghorse.net/home/stephan/
"Freedom is sloppy. But since tyranny's the only guaranteed byproduct of
those who insist on a perfect world, freedom will have to do." -- Bigby Wolf
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to