Looks good.

When I did that, I made clicking on anywhere in that div expand it.

You should also add a title that says "Click to expand" so that they don't
have to know/infer that the ellipsis is an active link.

I also like being able to shrink it back... right now there isn't that much
extra detail, but you may add more.

I don't want to sound critical or look a gift-horse in the mouth, but I
looked at your page source and it's way more complicated than it needs to
be.  If you look at my message in the other thread, all the code is there
to make it work with a lot less generated HTML and be a lot cleaner.

../Dave

On 25 November 2017 at 16:40, Richard Hipp <d...@sqlite.org> wrote:

> The names of the of the buttons are now "Advanced" and "Basic".  And
> they work by setting .style.display using JS.
>
> Timelines now come up in Basic mode, which means only the check-in
> comment shows.  There are ellipses at the end of each comment.  If you
> click on the ellipsis for one comment, it expands the (detail) section
> for that one timeline entry.
>
> Try it out:
>
>      https://www.fossil-scm.org/fossil/timeline
>      https://sqlite.org/srcx/timeline
>
> Problems:  (please suggest solutions)
>
> The ellipses at the ends of comments in basic mode are barely visible.
> And they are not configurable using CSS (at least not by any CSS that
> I know).
>
> That's the only serious problem that springs immediately to mind, but
> perhaps you can find others for me.
> --
> D. Richard Hipp
> d...@sqlite.org
> _______________________________________________
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to