On Jun 14, 2018, at 5:50 PM, John P. Rouillard wrote:
>
> In message <20180614213758.ga7...@britannica.bec.de>,
> Joerg Sonnenberger writes:
>>
>>
>> How do I develop a patch locally and send it to someone for review?
>
> Would some combination of:
>
> bundle
>
> published via
>
> uv mechanism
Back when I proposed the feature set that became bundles, I proposed that it
include a way for the outside contributor to create a ticket from a bundle,
which would be pushed to the remote repository for disposition by someone with
a commit bit.
That never happened, but now I think it’s another good reason for Fossil to
have a forum feature. Someone with a forum login on a repository but lacking a
commit bit could say
$ fossil bundle push --branch my-new-feature
and have their un-sync’d my-new-feature branch bundled and pushed to a
sub-forum dedicated to accepting unsolicited outside contributions.
Effectively, the new “push” verb is “fossil bundle export && send to
contribution sub-forum,” with the local Fossil instance transferring it
directly to the remote just as with the normal push feature.
Someone with a commit bit could then do a one-click integration of the bundle
branch from the forum UI, presumably after testing it locally on their machine.
There are several advantages to doing it through Fossil UI instead of the
current mechanism:
1. fossil bundle import && test && fossil bundle import --publish && send email
is more involved than fossil up my-new-feature && test && click “Integrate” in
Fossil UI.
2. Like closing a ticket combined merging a branch with --integrate, clicking
that button would auto-close both the forum thread and the branch.
3. By integrating it so tightly, the committer doesn’t need to explicitly
involve the local filesystem at all. The local Fossil instance gets a copy of
the bundled branch with the next sync past the outside contributor’s push, and
the integrate happens using that same contributed bundle. There’s no need to
rm ~/Downloads/my-new-feature.bundle after integrating the bundle, nor the
bulky email containing it.
4. Now we’d have pull requests to shut the Git fans up, except that they’d
actually be push requests. :)
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
