On Fri, April 18, 2008 17:17, Robert Riebisch wrote: > Tomas Hajny wrote: > >> 1) Previously, there've been two options for OptimizingGoalSwitches, but . . >> 3) As opposed to SetBooleanItem, SetLongintItem or SetStringItem, >> SetCurrSel unfortunately doesn't check if the selected index isn't >> beyond >> the amount of items within the associated collection (using ItemCount >> further referring to Items^.Count). . . > What is "a good solution"? :-)
Well, if you ask me, I'd say a good one should avoid similar problems in the future (i.e. fixing the SetCurrSel omission too as described above). ;-) > I just changed line 1438 to "SetCurrSel(0)" and it worked for me. File > "fp.cfg" was written properly and holds "-Os" as expected. > But wait... How do we turn "-Os" off? It's a single radio button after > "-OG" has been removed. I'd leave an answer for this to Jonas. The current situation doesn't make too much sense indeed. > I prepared a patch (GNU diff) to remove "OptimizingGoalSwitches" > completely and move "-Os" to "OptimizationSwitches": > <http://www.bttr-software.de/tmp/fpide_os.zip> Please review it for > mistakes, because I'm not very familiar with *Vision/OOP! :-) The patch looks OK (I haven't tested building, etc., but I assume you did). However, it would be probably useful to have some response from Jonas before applying it, maybe we don't need -Os at all now? > Afterwards I realized "Level x optimizations" being check boxes. I > think, that should be radio buttons instead. Furthermore "Position > independent code" and "Create smartlinkable units" seem to be at the > wrong place, because these are not "Run-time checks". Yes, this makes a lot of sense too. > P.S.: I signed up for bugs.freepascal.org several days ago, but never > got an activation mail. :-( Please, try it once more, just to make sure it wasn't some temporary one time issue. You should receive a response very quickly. If you don't, let us know, we'll forward this information to Marc so that he can have a look what's going on there (he is not subscribed to this list as far as I know). Tomas _______________________________________________ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
