Tomas Hajny wrote: > >> 3) As opposed to SetBooleanItem, SetLongintItem or SetStringItem, > >> SetCurrSel unfortunately doesn't check if the selected index isn't > >> beyond > >> the amount of items within the associated collection (using ItemCount > >> further referring to Items^.Count). > . > . > > What is "a good solution"? :-) > > Well, if you ask me, I'd say a good one should avoid similar problems in > the future (i.e. fixing the SetCurrSel omission too as described above). > ;-)
I see. :-) > > I just changed line 1438 to "SetCurrSel(0)" and it worked for me. File > > "fp.cfg" was written properly and holds "-Os" as expected. > > But wait... How do we turn "-Os" off? It's a single radio button after > > "-OG" has been removed. > > I'd leave an answer for this to Jonas. The current situation doesn't make > too much sense indeed. Who removed "-OG" and why? > > I prepared a patch (GNU diff) to remove "OptimizingGoalSwitches" > > completely and move "-Os" to "OptimizationSwitches": > > <http://www.bttr-software.de/tmp/fpide_os.zip> Please review it for > > mistakes, because I'm not very familiar with *Vision/OOP! :-) > > The patch looks OK (I haven't tested building, etc., but I assume you Yes, I did, of course. I'm happy, that I didn't forget all my Pascal knowledge, because I only looked through C code for the last two years. > did). However, it would be probably useful to have some response from > Jonas before applying it, maybe we don't need -Os at all now? Looks like he wants "-Os" AND "-OG" again. ;-) I welcome any decision as long as IDE looks consistently. > > Afterwards I realized "Level x optimizations" being check boxes. I > > think, that should be radio buttons instead. Furthermore "Position > > independent code" and "Create smartlinkable units" seem to be at the > > wrong place, because these are not "Run-time checks". > > Yes, this makes a lot of sense too. OK, but let's discuss first, before making another patch, which never will be applied. ;-) > > P.S.: I signed up for bugs.freepascal.org several days ago, but never > > got an activation mail. :-( > > Please, try it once more, just to make sure it wasn't some temporary one "That username is already being used." :-/ > time issue. You should receive a response very quickly. If you don't, let I also tried the "Lost password?" button, which tells me "Password Message Sent", but I don't get an e-mail. > us know, we'll forward this information to Marc so that he can have a look > what's going on there (he is not subscribed to this list as far as I > know). Please do so. :-) Robert Riebisch -- BTTR Software http://www.bttr-software.de/ _______________________________________________ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
