Not a major thing .... but. All examples for libfprint use function  
"discover_device" which looks strange:

struct fp_dscv_dev *discover_device(struct fp_dscv_dev  
**discovered_devs)
{
        struct fp_dscv_dev *ddev = NULL;
        int i;

        for (i = 0; ddev = discovered_devs[i]; i++) {
                struct fp_driver *drv = fp_dscv_dev_get_driver(ddev);
                printf("Found device claimed by %s driver\n",
                        fp_driver_get_full_name(drv));
                return ddev;
        }

        return ddev;
}

Unless I am greatly mistaken, "for" loop will run once (if  
discovered_devs is not empty) regardless of anything.  Should it be  
something like this, instead?

struct fp_dscv_dev *discover_device(struct fp_dscv_dev  
**discovered_devs)
{
        struct fp_dscv_dev *ddev = NULL;
        int i;

        for (i = 0; ddev = discovered_devs[i]; i++) {
                struct fp_driver *drv = fp_dscv_dev_get_driver(ddev);
                if( drv ) {
                printf("Found device claimed by %s driver\n",
                        fp_driver_get_full_name(drv));
                return ddev;
                }
        }

        return ddev;
}


_______________________________________________
fprint mailing list
[email protected]
http://lists.reactivated.net/mailman/listinfo/fprint

Reply via email to