On Tue, 2010-08-31 at 18:18 +0200, Hugo "Bonstra" Grostabussiat wrote: > On Tue, Aug 31, 2010 at 11:58, Bastien Nocera wrote: > > The changes to dev_discover are definitely wrong though. > > For the rest of the code, I'd rather you did not rename the fields, > > structures and enums to _2016 (and added a comment as to for which > > version the structures are for), or that you did it in a separate patch, > > otherwise it makes it very hard for me to review the patch. > > > > Right now, there's a bit too much churn for me to see that you're not > > breaking the old code. > > > > Finally, any chance you could create your patches against the git > > repository? This would allow me to include authorship information. > Those patches should be less messy and easier to review.
And pushed, after a couple of tiny fixes. Hugo, any chance you'd want to listen on the bugzilla bugs for libfprint? Would be of great help, as I don't have access to such a device. Cheers _______________________________________________ fprint mailing list [email protected] http://lists.reactivated.net/mailman/listinfo/fprint
