Okay, I've checked this stuff out..  Few helpful tips =)
  
- When generating a patch against CVS, please remember to update your local
  copy.
- Remember to remove your editors temporary files..
- look at your patch before posting it =)

ie., freeamp-hashstore-1.cvs.patch.gz is 525k.  If you remove all the junk in
the patch, it goes down to 35k.

On to comments 'bout what it's doing.  

- Shouldn't MetaData::SetCharStore be called before the music catalog is loaded?
- Memory usage before and after using the patch is identical.
  
  Tested by loading freeamp, adding all tracks in MyMusic to the current
  playlist, and playing it.
 
  CVS:       Size: 22624 RSS: 18832
  CVS+patch: Size: 22608 RSS: 18808

Isaac

On 28-Sep-2000 Chris Kuklewicz wrote:
> The patches can be downloaded from my MIT AFS account :
> http://web.mit.edu/chrisk/www/
> http://web.mit.edu/chrisk/www/freeamp-hashstore-1.cvs.patch.gz
> http://web.mit.edu/chrisk/www/freeamp-hashstore-1.beta9.patch.gz
> 
> Or my full tarball (from my personal machine, more space) :
> http://kuklewicz.mit.edu/
> http://kuklewicz.mit.edu/freeamp-hashstore-1.tar.gz
> 
> freeamp-hashstore-1.cvs.patch.gz is against latest CVS at 8:20PM EST
> on Sept. 27,2000 (made with diff -uPr -x CVS freeamp freeamp-hashstore
>| gzip > /home/shared/mit/freeamp-hashstore-1.cvs.patch.gz)
> 
> freeamp-hashstore-1.beta9.patch.gz is against 2.1 beta 9 tar.gz 
> 
> If people need a full 
> _______________________________________________
> [EMAIL PROTECTED]
> http://www.freeamp.org/mailman/listinfo/freeamp-dev
_______________________________________________
[EMAIL PROTECTED]
http://www.freeamp.org/mailman/listinfo/freeamp-dev

Reply via email to