Yup. that fixes the bug.  

root      6996  8.4  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      6997  0.0  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      6998  0.0  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      6999  0.0  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      7000  0.8  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      7001  0.2  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      7003  0.0  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      7004  0.0  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      7005  0.0  1.4 30228 9252 tty1     S    15:48   0:00 freeamp
root      7006  1.5  1.4 30228 9252 tty1     S    15:48   0:00 freeamp




On Fri, 2002-03-29 at 15:44, Ed Sweetman wrote:
> Yea i'd believe that if playing an mp3 didn't free up all that memory.  
> Why is freeamp using 60MB for playing a vorbis ogg file but only 4-5MB
> for mp3.  I think i found out why.
> 
> in your mp3 lmc xing does this 
> 
> iNewSize=max(iNewSize,iMinimumOutputBufferSize); 
> iNewSize *= 1024;
> 
> Seems logical
> 
> now in  the vorbis lmc it does this
> 
> iNewSize=max(iNewSize,iInitialOutputBufferSize);
> iNewSize *= 1024;
> 
> 
> Notice the difference. it's quite a lot.  here we have mp3 using "kbit"
> and vorbis using "bytes" ..i believe this is an oversight.  That's what
> you get for not specifying when you're using what.
> 
> Here we know const int32 iMinimumOutputBufferSize = 64; in lmc.h
> 
> both wavlmc and mp3 lmc use the same max( call.  Only vorbislmc is
> different and thus it's got a bug.  I'm not crazy.
> 
> On Fri, 2002-03-29 at 15:36, Chris Gray wrote:
> > On Fri, Mar 29, 2002 at 03:23:10PM -0500, Ed Sweetman wrote:
> > > I've verified that this is a vorbis problem with freeamp.  It is not a
> > > libvorbis problem, other players use under 2MB when playing vorbis
> > > files, freeamp uses 60MB    i'll take a look at the vorbis output code.
> > > 
> > > 
> > > On Fri, 2002-03-29 at 12:25, Ed Sweetman wrote:
> > > > I compile freeamp cvs with gcc 3.0.4 and upon loading with the default
> > > > theme, it uses 60MB of ram.  I tried as root and still the same thing.
> > > > 
> > > > root       601  1.5  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > > > root       602  0.0  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > > > root       603  0.0  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > > > root       604  0.0  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > > > root       605  1.4  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > > > root       606  0.0  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > > > root       608  0.6  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > > > root       610  0.0  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > > > root       611  0.0  9.4 107224 60916 tty1   S    12:21   0:00 freeamp
> > 
> > This is the xmms faq, but it is applicable here:
> > 
> > http://www.xmms.org/faq.html#r7
> > 
> > Cheers,
> > Chris
> > 
> 
> 
> _______________________________________________
> [EMAIL PROTECTED]
> http://www.freeamp.org/mailman/listinfo/freeamp-dev


_______________________________________________
[EMAIL PROTECTED]
http://www.freeamp.org/mailman/listinfo/freeamp-dev

Reply via email to