On Fri, Mar 29, 2002 at 03:44:39PM -0500, Ed Sweetman wrote:
> Yea i'd believe that if playing an mp3 didn't free up all that memory.  
> Why is freeamp using 60MB for playing a vorbis ogg file but only 4-5MB
> for mp3.  I think i found out why.

Ahh... I thought you were making the mistake of adding all the memory
sizes in all the processes together. 

> in your mp3 lmc xing does this 
> 
> iNewSize=max(iNewSize,iMinimumOutputBufferSize); 
> iNewSize *= 1024;
> 
> Seems logical
> 
> now in  the vorbis lmc it does this
> 
> iNewSize=max(iNewSize,iInitialOutputBufferSize);
> iNewSize *= 1024;
> 
> 
> Notice the difference. it's quite a lot.  here we have mp3 using "kbit"
> and vorbis using "bytes" ..i believe this is an oversight.  That's what
> you get for not specifying when you're using what.
> 


> Here we know const int32 iMinimumOutputBufferSize = 64; in lmc.h

And iInitialOutputBufferSize is 65536 in vorbislmc.cpp

> both wavlmc and mp3 lmc use the same max( call.  Only vorbislmc is
> different and thus it's got a bug.  I'm not crazy.

Good catch,
Chris

Attachment: msg01964/pgp00000.pgp
Description: PGP signature

Reply via email to