On Tue, May 14, 2002 at 01:33:26PM -0400, Ed Sweetman wrote:
> It's actually not standard to mount things inside /mnt   but rather /mnt
> be a mount point of some device.  
> 
> You should use /proc/mounts to look for cdrom fs's and query their
> mountpoints.   I think that would be better than hardcoding paths.  

Hm.  I know that RedHat at least uses /mnt/cdrom by default (also
/mnt/floppy for the floppy drives, etc), and I believe Mandrake does,
too.

Regardless, checking out /proc/mounts is a pretty good idea.  Should
it just scan for anything with an "iso9660" filesystem type?
Theoretically, you could run into problems with people mounting
ISOs on their system, but I suppose that's somewhat more rare.

Or would it make sense to actually use getmntent(3) to look for
an iso9660 fs in /etc/fstab?  That way you could be fairly
certain you're getting the "system" CDrom as opposed to just some
random ISO mounted loopback . . .

Let me know what you think and I'll submit a new patch.

-CJ

-- 
WOW: Nyctitropic         |  "Let us rain some DOOM upon the filthy heads
apocalyptech.com/wow     |             of our DOOMED enemies!"
[EMAIL PROTECTED]     |                    - Zim
_______________________________________________
[EMAIL PROTECTED]
http://www.freeamp.org/mailman/listinfo/freeamp-dev

Reply via email to