> On Mar 18, 2015, at 9:59 AM, Anthony Jenkins <[email protected]> > wrote: > > On 03/18/2015 11:26 AM, Warner Losh wrote: >> Looking at patch 5: >> >> You need to rework this so there’s an atrtc_acpi.c. Put all the ACPI >> attachment in there. > > Okay, shouldn't be a problem. > >> You should also split off the little bit that’s ISA-specific into atrtc_isa. > > You mean rtcin() and writertc()? ...but that's not my stuff, it was > already in atrtc.c. PNP0800 (the PC-AT RTC component) is (practically) > an ISA-specific device.
There will be a small “isa” specific driver. Here ISA means ‘FreeBSD ISA attachment’ not necessarily what you’d find on an ISA bus. This means you’d have two separate driver statement. You can then do the ACPI stuff in the ACPI attachment and not have to worry about whether or not it is compiled into the kernel, since you’d only include it if acpi is in the kernel. Warner
signature.asc
Description: Message signed with OpenPGP using GPGMail
