On 9 Jan, Dag-Erling Smørgrav wrote: > Don Lewis <truck...@freebsd.org> writes: >> After staring at the code a lot more, I see your point about the loss of >> information. The problem is that openpam_parse_chain() returns >> PAM_SUCCESS whether or not if found anything, but we want the loop to >> terminate when either an error is detected or if openpam_parse_chain() >> actually found something. Maybe changing the loop exit to something >> like this would work: >> >> if (ret != PAM_SUCCESS || pamh->chains[facility] != NULL) >> return (ret); > > The simplest fix for now is probably to revert r487; it applies cleanly > except for the first hunk, which is easy to apply manually.
openpam_configure() checks whether or not pamh->chains[] is NULL, so I figured that was a good test once I figured out how openpam_parse_chain() was returning its results. Once you decide on a fix, I can move my old /etc/pam.conf back to test it. _______________________________________________ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
