On 01/29/14 09:49, Lundberg, Johannes wrote:

I tested the driver on a 2012 Macbook Air 11" and it works great! Good job!

Is there a way to disable click-by-touch? I always preferred clicking with
the physical button that is built in to the pad.


I've added an "#if 0" around the 1 finger tap code until further. Maybe this feature can be tunable?

I fixed the code style, added some range checks and cleared some buffer issues.

When you assign a signed value to an unsigned variable, you should range check it, because the sign might cause an overflow when you use it later on.

int8_t x = -1;

uint32_t t = x;

"t" is now "0xffffffffU" and not "255".

Tested the code on my MacBookPro. Hope I didn't break anything. If so, send a patch to freebsd-usb.


To get the touchpad working with Xorg, I needed to re-compile HALD with the attached patch.

kwm: Can you get the attached patch into ports?

Auto-loading of wsp via devd will be done later. Simply need to re-generate usb.conf in /etc ...


--- patch-hald_freebsd_hf-usb2.c.orig	2014-01-29 11:50:11.000000000 +0100
+++ patch-hald_freebsd_hf-usb2.c	2014-01-29 11:50:36.000000000 +0100
@@ -61,7 +61,7 @@
 +			if (driver) {
 +				if (!strcmp(driver, "ukbd"))
 +					hf_device_set_input(device, "keyboard", "keys", NULL);
-+				else if (!strcmp(driver, "ums") || !strcmp(driver, "atp")) {
++				else if (!strcmp(driver, "ums") || !strcmp(driver, "atp") || !strcmp(driver, "wsp")) {
 +					hf_device_set_input(device, "mouse", NULL, devname);
 +					hf_runner_run_sync(device, 0, "hald-probe-mouse", NULL);
 +				} else if (!strcmp(driver, "uhid")) {
freebsd-current@freebsd.org mailing list
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Reply via email to