On 17 Oct 2015, at 09:09, NGie Cooper <yaneurab...@gmail.com> wrote:
...
> Also, this logic looks troublesome:
>
> 42 .if empty(TOOLSDIR) || !exists(${TOOLSDIR}/usr/bin/clang-tblgen)
> 43 .if ${MACHINE} == "host" && defined(BOOTSTRAPPING_TOOLS)
> 44 .if !empty(LEGACY_TOOLS) && exists(${LEGACY_TOOLS}/usr/bin/tblgen)
> 45 TOOLSDIR= ${LEGACY_TOOLS}
> 46 .endif
> 47 .endif
> 48 .if ${MK_STAGING} == "yes" &&
> exists(${STAGE_HOST_OBJTOP:Uno}/usr/bin/tblgen)
> 49 TOOLSDIR= ${STAGE_HOST_OBJTOP}
> 50 .endif
> 51 .if exists(${LEGACY_TOOLS:Uno}/usr/bin/tblgen)
> 52 TOOLSDIR= ${LEGACY_TOOLS}
> 53 .endif
> 54 .endif
> 55 TOOLSDIR?=
> 56 .if !empty(TOOLSDIR) && exists(${TOOLSDIR}/usr/bin/clang-tblgen)
> 57 TBLGEN= ${TOOLSDIR}/usr/bin/tblgen
> 58 CLANG_TBLGEN= ${TOOLSDIR}/usr/bin/clang-tblgen
> 59 .endif
> 60 TBLGEN?= tblgen
> 61 CLANG_TBLGEN?= clang-tblgen
>
> This kind of complexity matched something that I simplified at $work due to
> build races…This stuff was added by sjg as part of his meta-mode commit frenzy in r284345, but I never really agreed to it, nor do I understand what its function is. It was just splattered all over the tree. Can we just remove it for now, and put it back when it works, and is actually used for something? :-) -Dimitry
signature.asc
Description: Message signed with OpenPGP using GPGMail
