On 02-Nov-00 Marcel Moolenaar wrote:
> John Baldwin wrote:
>> 
>> Quick question: Is this a problem for people _without_ DEVFS? 
> 
> That's a yes for me.
> 
>> non-DEVFS case.  Try this hackish patch:
>> 
>> Index: bpf.c
>> ===================================================================
>> RCS file: /usr/cvs/src/sys/net/bpf.c,v
>> retrieving revision 1.68
>> diff -u -r1.68 bpf.c
>> --- bpf.c       2000/10/09 14:19:09     1.68
>> +++ bpf.c       2000/11/02 20:26:09
>> @@ -363,7 +363,7 @@
>>          */
>>         if (d)
>>                 return (EBUSY);
>> -       if (!dev->si_flags & SI_NAMED)
>> +       if (!devfs_present)
>>                 make_dev(&bpf_cdevsw, minor(dev), UID_ROOT, GID_WHEEL, 0600,
>>                     "bpf%d", dev2unit(dev));
>>         MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK);
>> 
>> Hmm.  Or try doing changing it to this instead:
>> 
>>         if (dev->si_flags & SI_NAMED != 0)
>> 
>> It could be an order of operations buglet.
> 
> Give me a couple of days to play with it...

I already managed to test it locally here and commit the proper fix.
It was an order of operations bug due to the fact that ! is
evaluated before &.

-- 

John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to