Re: "make modules" kicks the first module directory twice

[Marcel Moolenaar]

[-stable removed from the cc list]

Makoto MATSUSHITA wrote:
> 
> marcel> No you can't. $S expands to "../.." which only works for the
> marcel> first cd in the -jX case. The second cd will fail.
> 
> Ouch...

Sorry :-)

> give me one more chance to submit a patch. Here's summary:

You're not going to like this:

>   modules-depend:
>         @mkdir -p ${.OBJDIR}/modules
> !       cd $S/modules; env ${MKMODULESENV} ${MAKE} obj
> !       env ${MKMODULESENV} ${MAKE} depend

For the non parallel case this doesn't work, because the "${MAKE}
depend" is not run from the right directory (ie "$S/modules") because
the second make doesn't get started from the same shell. Example:

gauss% more ~/mf
all:
        cd ../marcel; pwd
        pwd

*** Non-parallel case

gauss% cd /xtra/ncvs
gauss% make -f ~/mf
cd ../marcel; pwd
/xtra/marcel
pwd
/xtra/ncvs

*** Parallel case

gauss% make -f ~/mf -j2
cd ../marcel; pwd
/xtra/marcel
pwd
/xtra/marcel

...other than that... :-)

-- 
Marcel Moolenaar
  mail: [EMAIL PROTECTED] / [EMAIL PROTECTED]
  tel:  (408) 447-4222


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message