On Wed, 10 Apr 2002, Alexander Leidinger wrote:

> As for other occourences of the use of __GNUC__ without a check if it is
> defined: I will wrap them as soon as I review my own patches again.

Other occurrences are mostly correct.  __GNUC__ is 0 in cpp expressions
if it is used without it being defined.  The problem with the ifdef in
quad.h is that it defaults to the gcc-1 case if __GNUC__ is not >= 2.
The ifdef should have been written something like:

#if __GNUC__ == 1
typedef u_quad_t        qshift_t;
typedef u_int           qshift_t;

assuming that u_int really is "correct" for shift counts.  (Shift counts
can be of any integer type; it is just not useful to use a large type
for them since shifting by an amount larger than the number of bits in
the operand being shifted is undefined.)


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to