> Marc Recht <[EMAIL PROTECTED]> writes:
> I've had the attached patch in my tree for a while.  I'll try and get
> it and the <unistd.h> patch committed today.

    static __inline void
    __fd_zero(fd_set *p, __size_t n)
    {
            n = _howmany(n, _NFDBITS);
            while (n > 0)
                    p->fds_bits[n--] = 0;
    }

That looks broken. Maybe you meant this:

    static __inline void
    __fd_zero(fd_set *p, __size_t n)
    {
            n = _howmany(n, _NFDBITS);
            while (n > 0)
                    p->fds_bits[--n] = 0;
    }

But why not just this?

    static __inline void
    __fd_zero(fd_set *p, __size_t n)
    {
            memset(p->fds_bits, 0, _howmany(n, _NFDBITS));
    }

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to