On Mon, May 12, 2014 at 7:01 PM, bycn82 <byc...@gmail.com> wrote:
> On 5/9/14 0:11, bycn82 wrote:
>
...
> Done ,submitted.
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/189721
>
can you clean up the formatting and style
(including some gratuitous whitespace changes).
Also there are several things to fix:
- please use { } even for blocks with a single statement
- please make count and duration 32 bit values. 16 bits are way
too little for count, and there is no point to be stingy with count
- count should not be incremented upon a 'DENY' or it could wrap
(very risky for 16-bit values);
cheers
luigi
_______________________________________________
freebsd-ipfw@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"
