On Sunday 26 June 2005 17:52, Sascha Luck wrote: > On Sun, Jun 26, 2005 at 04:48:31PM +0200, Max Laier wrote: > > Can you verify that it breaks with if_pfsync.c,rev. 1.16? Unfortunately, > > rev. 1.17 happend just one hour after 1.16 and also includes serious > > changes to pfsync. > > I've rebuilt both with 1.16 and there now is pfsync traffic. Yep, and state > tables are being synchronised again too. :)
Can you try the attached patch, please? I forgot to initialize ifq_maxlen, it seems :-\ -- /"\ Best regards, | [EMAIL PROTECTED] \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | [EMAIL PROTECTED] / \ ASCII Ribbon Campaign | Against HTML Mail and News
Index: if_pfsync.c =================================================================== RCS file: /usr/store/mlaier/fcvs/src/sys/contrib/pf/net/if_pfsync.c,v retrieving revision 1.18 diff -u -r1.18 if_pfsync.c --- if_pfsync.c 12 Jun 2005 16:46:20 -0000 1.18 +++ if_pfsync.c 26 Jun 2005 16:15:49 -0000 @@ -224,6 +224,7 @@ callout_init(&sc->sc_bulk_tmo, NET_CALLOUT_MPSAFE); callout_init(&sc->sc_bulkfail_tmo, NET_CALLOUT_MPSAFE); callout_init(&sc->sc_send_tmo, NET_CALLOUT_MPSAFE); + &sc->sc_ifq.ifq_maxlen = 64; mtx_init(&sc->sc_ifq.ifq_mtx, ifp->if_xname, "pfsync send queue", MTX_DEF); if_attach(ifp); @@ -1797,7 +1798,7 @@ pfsyncstats.pfsyncs_opackets++; #ifdef __FreeBSD__ - if (IF_HANDOFF(&sc->sc_ifq, m, NULL)) + if (!IF_HANDOFF(&sc->sc_ifq, m, NULL)) pfsyncstats.pfsyncs_oerrors++; callout_reset(&sc->sc_send_tmo, 1, pfsync_senddef, sc); #else
pgpUYns9usZ1k.pgp
Description: PGP signature
