On Sunday 26 June 2005 18:40, Sascha Luck wrote: > On Sun, Jun 26, 2005 at 06:17:14PM +0200, Max Laier wrote: > > Can you try the attached patch, please? I forgot to initialize > > ifq_maxlen, it seems :-\ > > That breaks: > > cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -Wall > -Wredundant-decls -Wnested-externs -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual > -fformat-extensions -std=c99 -nostdinc -I- -I. -I../../.. > -I../../../contrib/dev/acpica -I../../../contrib/altq -I../../../contrib > /ipfilter -I../../../contrib/pf -I../../../contrib/dev/ath -I../../.. > /contrib/dev/ath/freebsd -I../../../contrib/ngatm -I../../../dev/twa > -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 --param > inline-unit-growth=100 --param large-function-growth=1000 -mcmodel=kernel > -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow > -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror > ../../../contrib/pf/net/if_pfsync.c ../../../contrib/pf/net/if_pfsync.c: In > function `pfsync_clone_create': ../../../contrib/pf/net/if_pfsync.c:227: > error: invalid lvalue in assignment *** Error code 1
It's just one of these days, I guess ... please use this patch instead or remove the "&" in line 227. Sorry. -- /"\ Best regards, | [EMAIL PROTECTED] \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | [EMAIL PROTECTED] / \ ASCII Ribbon Campaign | Against HTML Mail and News
Index: if_pfsync.c =================================================================== RCS file: /usr/store/mlaier/fcvs/src/sys/contrib/pf/net/if_pfsync.c,v retrieving revision 1.18 diff -u -r1.18 if_pfsync.c --- if_pfsync.c 12 Jun 2005 16:46:20 -0000 1.18 +++ if_pfsync.c 26 Jun 2005 16:15:49 -0000 @@ -224,6 +224,7 @@ callout_init(&sc->sc_bulk_tmo, NET_CALLOUT_MPSAFE); callout_init(&sc->sc_bulkfail_tmo, NET_CALLOUT_MPSAFE); callout_init(&sc->sc_send_tmo, NET_CALLOUT_MPSAFE); + sc->sc_ifq.ifq_maxlen = 64; mtx_init(&sc->sc_ifq.ifq_mtx, ifp->if_xname, "pfsync send queue", MTX_DEF); if_attach(ifp); @@ -1797,7 +1798,7 @@ pfsyncstats.pfsyncs_opackets++; #ifdef __FreeBSD__ - if (IF_HANDOFF(&sc->sc_ifq, m, NULL)) + if (!IF_HANDOFF(&sc->sc_ifq, m, NULL)) pfsyncstats.pfsyncs_oerrors++; callout_reset(&sc->sc_send_tmo, 1, pfsync_senddef, sc); #else
pgpIHpRhmvoL9.pgp
Description: PGP signature
