Stephen Montgomery-Smith píše v st 23. 05. 2007 v 20:04 -0500:

> I'm getting kind of uncomfortable with the patch.  I looked some more
> in 
> bsd.gnome.mk and it seems to me that the suggested patch is really 
> equivalent to the patch enclosed here.
> 
> Why did the writer of bsd.gnome.mk have the rather complicated 
> construction which I am proposing to replace?

I don't know, we'd have to ask Joe Marcus. Here is the revision in
question:

http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.gnome.mk.diff?r1=1.22;r2=1.23

You're basically reverting that revision. Perhaps our make(1) wasn't
smart enough those four years ago, I don't know.

> Prostý textový dokument příloha (eee)
> --- bsd.gnome.mk-orig Mon Mar 19 23:13:36 2007
> +++ bsd.gnome.mk      Wed May 23 19:25:19 2007
> @@ -689,9 +689,9 @@
>  
>  # Then traverse through all components, check which of them
>  # exist in ${_USE_GNOME} and set variables accordingly
> +.ifdef _USE_GNOME
>  . for component in ${_USE_GNOME_ALL}
> -_COMP_TEST=  ${_USE_GNOME:M${component}}
> -.  if ${_COMP_TEST:S/${component}//}!=${_COMP_TEST:S/  / /g}
> +.  if ${_USE_GNOME:M${component}}!=""
>  PATCH_DEPENDS+=      ${${component}_PATCH_DEPENDS}
>  FETCH_DEPENDS+=      ${${component}_FETCH_DEPENDS}
>  EXTRACT_DEPENDS+=${${component}_EXTRACT_DEPENDS}
> @@ -725,6 +725,7 @@
>  
>  .  endif
>  . endfor
> +.endif
>  .endif
>  
>  .if defined(GNOME_PRE_PATCH)
-- 
Pav Lucistnik <[EMAIL PROTECTED]>
              <[EMAIL PROTECTED]>

The Linimon's Rule: The More You Close, The More Will Come

Attachment: signature.asc
Description: Toto je digitálně podepsaná část zprávy

Reply via email to