On Fri, 15 Jul 2011, Pav Lucistnik wrote:
Warren Block píše v pá 15. 07. 2011 v 07:15 -0600:
It could also be made polymorphic, basing what it does on the
number of fields rather than a new DESKTOP_ENTRIESv2 define.
I believe that's impossible because you can create several desktop
entries by repeating the quadruple of values in this variable.
Quite similar to OPTIONS.
It would be just like the error check at the start of the routine, look
for an even multiple of 6 or 7 fields.
But that brings up another problem. All desktop entries would have to
be the same type. Can't set the filename for one and leave the others
alone. Unless empty fields are used to mean a default filename, and
that just makes it more complicated for a rare situation.
FWIW, I think the original code with a better regex like Jung-uk Kim has
in http://lists.freebsd.org/pipermail/freebsd-ports/2011-July/068737.html
is still the way to go. If the port requires a special desktop entry
filename, that seems beyond the scope of the DESKTOP_ENTRIES variable.
This all should be documented in the Porter's Handbook, and I'll
volunteer to work on the DESKTOP_ENTRIES section once there's a decision
on the code._______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[email protected]"
