On Sun, 2012-11-18 at 14:40 +0000, Chris Rees wrote: > On 17 November 2012 22:59, Hiroki Sato <[email protected]> wrote: > > > > I think it is safe to remove the warning message when rc_quiet=YES. > > What do you think about the attached patch? > > I had originally considered that, but it then makes dhclient behave > differently from other scripts; nothing else respects rc_quiet in this > fashion; > > from rc.subr: > start) > if [ -z "$rc_fast" -a -n "$rc_pid" ]; then > echo 1>&2 "${name} already running? > (pid=$rc_pid)." > return 1 > fi > and > > [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart > musicpd already running? (pid=83847). > > Chris
If not via the rc_quiet mechanism, then please silence it via some other mechanism *to restore historical behavior*. In the past, rc.d/dhclient had its own silent pidfile check and in general the design was to be silently idempotent (presumably because of the way it gets invoked multiple times for the same inteface during rc processing). Somewhere along the line it was changed to use new common rc.subr code to handle the pidfile check, but because the new code is not silent it wasn't really equivelent to the old code. As far as I'm concerned the switch to the new noisy pidfile check for dhclient amounts to the introduction of a bug. If it doesn't get changed I can see years of explaining to customers (who seem to have nothing better to do than spelunk system logs) "don't worry about that, it's normal." -- Ian _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-rc To unsubscribe, send any mail to "[email protected]"
