On 18 Nov 2012 15:17, "Hiroki Sato" <[email protected]> wrote: > > Chris Rees <[email protected]> wrote > in <[email protected]>: > > cr> The following reply was made to PR bin/165477; it has been noted by GNATS. > cr> > cr> From: Chris Rees <[email protected]> > cr> To: Hiroki Sato <[email protected]> > cr> Cc: [email protected], "[email protected]" < [email protected]>, > cr> "[email protected]" <[email protected]> > cr> Subject: Re: bin/165477: [rc] dhclient is run twice > cr> Date: Sun, 18 Nov 2012 14:40:00 +0000 > cr> > cr> On 17 November 2012 22:59, Hiroki Sato <[email protected]> wrote: > cr> > > cr> > I think it is safe to remove the warning message when rc_quiet=YES. > cr> > What do you think about the attached patch? > cr> > cr> I had originally considered that, but it then makes dhclient behave > cr> differently from other scripts; nothing else respects rc_quiet in this > cr> fashion; > cr> > cr> from rc.subr: > cr> start) > cr> if [ -z "$rc_fast" -a -n "$rc_pid" ]; then > cr> echo 1>&2 "${name} already running? > cr> (pid=$rc_pid)." > cr> return 1 > cr> fi > cr> and > cr> > cr> [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart > cr> musicpd already running? (pid=83847). > > I cannot understand why the dhclient script behaves differently from > the others after patching rc.subr. Did you read the attached patch > in my previous email?
I read the patch, but not the filename-- I'm sorry that Sunday afternoons are clearly not a good time for me to review code :( If you want to respect rc_quiet in rc.subr for the already running case, then I think that's fine. Chris _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-rc To unsubscribe, send any mail to "[email protected]"
