On Tue, 16 Feb 2010 12:59, freebsd@ wrote:
On Tue, Feb 16, 2010 at 11:06:43AM -0600, Barry Pederson wrote:
On 2/15/10 7:49 PM, jhell wrote:
As I make final modifications to the script I will keep the below URLs
updated and welcome any bug reports or modification requests to me
personally.
Here is the URLs:
http://jhell.googlecode.com/files/arc_summary.pl
http://jhell.googlecode.com/files/arc_summary.pl.asc
Nice. How about including relevant lines from /boot/loader.conf,
maybe something like this tacked on the end of the script (excuse my
Perl, I'm a Python guy).
----
#### Loader Settings #############
open(LOADER, '/boot/loader.conf');
print "\n/boot/loader.conf settings:\n";
while (<LOADER>){
chomp;
if (/^\s*(zfs|vfs\.zfs|vm\.kmem)/){
print "\t$_\n";
}
}
----
Yes, it should more or less duplicate the sysctl values, but it may
make it more obvious where the settings are coming from, or if the
user has bad or ignored settings
Major problems with the above code:
1) Opens /boot/loader.conf for rw access; should be read-only
2) Makes the assumption /boot/loader.conf exists
3) Does not close the fd
4) Excessively quotes variables for no justified reason
5) Makes some bad assumptions about the contents of the file (ex.
comments with the word "zfs" in them would match)
The code should really be something like what's below. This should
be much more manageable as well (@tunables that is), although I always
worry when using grep()...
Very nice!,
Ill keep this for reference later on. This might just come in handy at
some point.
But for the sake of arc_summary.pl I feel this is beyond the scope of what
its intended use is. See previous email in response to Barry.
Thanks Jeremy
--
jhell
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "[email protected]"
