On 06/01/12 20:10, Engineering wrote:
-----Original Message-----
From: Hans Petter Selasky [mailto:hsela...@c2i.net]

I think mav @ did some work in that area?

Are you sure you cannot use:
          if (id != 0)
                       copyin(ugd->ugd_data,&id, 1);
                error = uhid_set_report(sc, ugd->ugd_report_type, id,
                    NULL, ugd->ugd_data, imin(ugd->ugd_maxlen, size));

That's definitely cleaner, using the ugd fields to denote a special case.
I'm not sure about the (id != 0) - I'll need to check my specific devices,
but something like:

Hans is right. That code should do the trick. Last year I've fixed uhid driver to handle multiple report IDs. Even user-level tools are able to do it now. "id != 0" should be correct condition. According to HID spec, if device has at least one non-zero report ID, report ID should be included into any transfer. So now uhid driver assumes that report ID should be in the first byte of request, if it found some non-zero ID in descriptor.

Alexander Motin
freebsd-usb@freebsd.org mailing list
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"

Reply via email to