On Monday, October 27, 2014 12:47:13 PM Conrad Meyer wrote: > Hi John, > > I don't have access to phabricator so I'll try and review in email. > > > +#ifdef XEN > > +int vm_guest = VM_GUEST_XEN; > > +#else > > +int vm_guest = VM_GUEST_NO; /* Running as virtual machine guest? */ > > +#endif > > The whitespace between 'int' and 'vm_guest' in the second line seems > wrong (extra space?).
Yep, fixed. > For vmware_hvcall() in x86/include/vmware.h, are you sure the inline > assembly is correct? Have you tried the detection on a VMware VM? > VMware's documentation specifies the arguments in a different > order, and at Isilon when we tried the port-based detection in a > slightly older revision of CURRENT, it didn't work (IIRC). I don't have VMware handy, but it is a simple copy and paste of existing code in tsc.c. -- John Baldwin _______________________________________________ firstname.lastname@example.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization To unsubscribe, send any mail to "freebsd-virtualization-unsubscr...@freebsd.org"