<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39577 >

Pepeto _ wrote:
> But wipe_unit(vunit) in 2.0 is needed, because transfer_unit() makes
> already a new unit. In 2.1, the same structure is used, so there is no
> problem.
Then that's a bug in transfer_unit().  My fix prevents a reported crash in
the following line at unit_list_unlink, an invalid vunit.  You cannot wipe
the unit before unlinking:

   unit_list_unlink(units, vunit);

Clearly, you never tested your proposed patch.  That makes all your other
patches suspect.

Moreover, the code in 2.0 is so bad, it's a waste of time.  Live with

Freeciv-dev mailing list

Reply via email to