<URL: http://bugs.freeciv.org/Ticket/Display.html?id=40338 >

Marko Lindqvist wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=40338 >
>  - This patch makes max size of freshwater lakes configurable.
> Anything bigger than this is ocean, anything smaller is lake
>  - Fixed reversed logic
>  - Removed lakes from civ1 & civ2 rulesets, still present in default rules.
>  Either lakes need to be removed from default ruleset too, or separate
> graphics should be created for them. I'm in favor of keeping them as
> separate terrain that does not have Whales around.
>  It seems that regenerate_water() is still not always used in initial
> map generator. This patch can be tested by "Regenerate water" in
> editor mode.

-      if (DEFAULT_LAKE_SEA_SIZE < ocean_sizes[-here]
+      if (terrain_control.lake_max_size >= ocean_sizes[-here]
            && num_laketypes > 0) {
          tile_change_terrain(ptile, lakes[myrand(num_laketypes)]);

Isn't this check backwards?


Freeciv-dev mailing list

Reply via email to