Follow-up Comment #1, bug #14418 (project freeciv):

Yesterdays code snippet had another kind of error - it's worth checking that
there is no more similar ones.

(4 - (game.info.num_base_types % 4)) was used to tell how many bits there is
left over from last 4 bit block. When game.info.num_base_types is multiply of
4
thus returns 4 - 0 = 4. It really should be 0.

Fixing this may break savegame compatibility with existing S2_2 saves if
saves contain 4+4 bits (instead of just 4) bits for our 4 bases. Still, it's
better to break savegame compatibility with unstable development revisions
than to leave bug there (savegame compatibility will not be broken with any
stable release).

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?14418>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to