Update of bug #18513 (project freeciv): Status: None => Ready For Test Planned Release: => 2.3.1, 2.4.0 Summary: Bases & Terrain(class) changes => Bases removesd because changing terrain remain as border source, vision source
_______________________________________________________ Follow-up Comment #1: Applicable requirements are checked when terrain changes, and base is removed if they are no longer fulfilled. There is problem in this though. Removal is done in common code using tile_remove_base(). This is not enough in server side, as it won't remove border source or vision. Attached fix may seem too big change to S2_3 introducing completely new module, libfreeciv, with callback interface. However I think this is so much cleaner and more robust solution than trying to remove base removal from common code and to hack every place in server where terrain may change, that it actually is more safe. (file #13953, file #13954) _______________________________________________________ Additional Item Attachment: File name: DestroyBaseCB.diff Size:5 KB File name: DestroyBaseCB-S2_3.diff Size:5 KB _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?18513> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev