Summary: Buildings costing upkeep money not considered for
forced selling
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sat 25 Feb 2012 03:29:38 PM EET
                Category: general
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None
         Planned Release: 



Reserving bug #19494 for single bug of constructing cityimpr list with
identical entries, I open separate tickets for other problems I've noticed in
forced sell code.

While list of potential buildings to sell is constructed,
can_city_sell_building() check is used, yet we assume that selling all the
buildings in that list alone always brings treasury to at least zero. What if
there are unsellable buildings with upkeep. They took many, but that cannot be
restored by forced selling them. I can think two cases:
- Wonder with upkeep. Do we support that in the first place, or should we
sanity check rulesets against it?
- City has already sold building this turn. Note that limitation of selling
only one building / turn applies only in construction of the list. If all the
buildings in the city end to the list (city had not sold anything), later loop
to sell buildings is happy to sell them all, not just one / city.


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to