Summary: Client's limited knowledged used when displaying
military unhappiness caused by unit
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Thu 26 Jul 2012 11:33:20 AM EEST
                Category: client
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None
         Planned Release: 



Client can display completely bogus information about military unhappiness
caused by units, since it tries to determine it itself with its limited
knowledge. I have not checked all clients carefully, but from quick grepping
it seems that broken code exist in all of them.

1. It gets value of effect EFT_MAKE_CONTENT_MIL to decide how many units get
free upkeep. Client may end up displaying wrong number of units free of
happiness upkeep
2. It calls city_unit_unhappiness() for each unit, which for units in fortress
ends up checking if there's friendly city nearby. There could be allied city
near that player does not know about (it would make sense that unknown cities
would not lift unhappiness, but as server side does not work that way, client
ends showing wrong information)


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to