URL:
  <http://gna.org/bugs/?20007>

                 Summary: script_fcdb_init() calls luascript_destroy(NULL)
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Mon 30 Jul 2012 07:23:44 PM EEST
                Category: general
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 

    _______________________________________________________

Details:

I don't know if this harmful or not, but certainly looks suspicious.

script_fcdb.c:196 checks that fcl certainly is NULL, and then calls
luascript_destroy(fcl)

Also, there's shadowing of module wide static variable fcl in some of the
functions in this file. Shadowing should be avoided (I remember that we used
to get compiler warning about it, wondering why it's not accepted)




    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?20007>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to