Follow-up Comment #10, bug #20003 (project freeciv): > I see two possible ways to fix this.
Well, third one is what I've planned to do for a long time*: give dio_get_xxx() functions return values telling if they succeeded or failed. Patch attached. *) According to very old TODO I had actually foreseen possibility of infinite loop somewhere when I first came across the dio_get_xxx() functions and noticed their lack of return value. Any volunteers to do throughout checking of all dio_get_xxx() callers in case there's other places where return values (added by this patch) should be checked. (file #16260, file #16261, file #16262, file #16263) _______________________________________________________ Additional Item Attachment: File name: RetvalForDioGet.patch Size:14 KB File name: RetvalForDioGet-S2_3.patch Size:12 KB File name: RetvalForDioGet-S2_2.patch Size:13 KB File name: RetvalForDioGet-S2_0.patch Size:12 KB _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?20003> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freecivfirstname.lastname@example.org https://mail.gna.org/listinfo/freeciv-dev