Summary: AI considers unit to get 2 veteran levels in civ2
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Wed 10 Oct 2012 12:17:25 AM EEST
                Category: ai
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.5.0



I got failed assert with civ2 ruleset from get_virtual_defense_power()
considering virtual unit to get 2 veteran levels (barracks + Sun Tzu?)

That's due to do_unit_virtual() returning just the veteran build effect value.
When we did related fix to unit building, it was the caller, not
do_unit_virtual(), that implemented the cap. Other callers are still broken.

Fix attached.

I still need to check if stable branches - with just boolean veterancy effect
- need similar fix for units that have just 1 veterancy level (i.e. cannot get
any veterancy)


File Attachments:

Date: Wed 10 Oct 2012 12:17:25 AM EEST  Name: Civ2LimitVeteranLevels.patch 
Size: 996B   By: cazfi



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to