Follow-up Comment #6, patch #4077 (project freeciv):

Read the pathc, not tested yet. Looks promising, though I found some
nitpicking:

- As you touch the code blocks in clients by moving them, you could and should
fix the style:

if(xxx)
  single_line();

->

if (xxx) {
  single_line();
}

- There was "true" and "false" used instead of "TRUE" and "FALSE" at least in
one place
- In actions.c add comment about the directory include files reside
- Comment typofix "pleace" -> "please"
- "disbled" -> "disabled"
- Capitalize also second word in gen_actions specenum names "Poison City",
"Sabotage Unit"
- Unless you have good reason not to, move either action_init() or
action_free() call so that various frees are in reverse order to inits
(lifetime of one object type is contained within lifetime of another object
type)
- action_init() and action_free() should be plural instead: actions_init() &
actions_free()


    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?4077>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to