URL:
  <http://gna.org/patch/?4097>

                 Summary: Kill diplstate_text(), use diplstate_type_name()
                 Project: Freeciv
            Submitted by: sveinung
            Submitted on: Mon 19 Aug 2013 02:17:45 PM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 

    _______________________________________________________

Details:

The names in diplstate_text() is qualified. The enum must be untranslated as
it is used when reading from the rule set. Solve this by making other users of
the same string (that I assume can be translated differently) qualified.

Changes:
 * Qualify "Team" used as a label.
 * Mark the names in the spec enum as translateble
 * Replace diplstate_text(state) with _(diplstate_type_name(state))

Only tested lightly. (Started the gtk2, gtk3, qt and sdl clients. Looking at
nations and, except for qt, intelligence)

Is the approach OK? Any suggestions for more tests?



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 19 Aug 2013 02:17:45 PM GMT  Name: kill_diplstate_text.patch  Size:
10kB   By: sveinung

<http://gna.org/patch/download.php?file_id=18711>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?4097>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to