URL:
<http://gna.org/patch/?4679>
Summary: Remove nreqs support entirely
Project: Freeciv
Submitted by: persia
Submitted on: Wed 30 Apr 2014 01:01:42 PM JST
Category: general
Priority: 5 - Normal
Status: Need Info
Privacy: Public
Assigned to: persia
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.6.0
_______________________________________________________
Details:
As nreqs are no longer used in the default rulesets, there is no reason to
continue having engine support. The attached patch removes it all, leaving a
ruleset error on ruleset load if a ruleset uses nreqs (the network capstring
is known wrong, but I didn't want to forget adding it later).
I'm not entirely happy with the construction I used to test for the
presence of nreqs in the ruleset: suggestions for a better implementation (not
using reqs->size, which ought be private) welcomed.
This patch has not been extensively tested: it is posted more for review
for completeness and verification of the intent than as a direct commit
candidate. I'm confident there will need to be changes before application
(for example, I doubt I removed enough code from ruledit).
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Wed 30 Apr 2014 01:01:42 PM JST Name: remove-nreqs-support.patch Size:
17kB By: persia
<http://gna.org/patch/download.php?file_id=20616>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?4679>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
