URL:
  <http://gna.org/bugs/?22148>

                 Summary: Sdl(2)-client nation selection dialog shows first
city style twice
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sat 07 Jun 2014 03:29:23 AM EEST
                Category: client-sdl2
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.6.0

    _______________________________________________________

Details:

2.5 had quite weird implementation of two iterations over city styles, of
which first one *set* len to width of the icon, and "break" away after that
first one. Second iteration skipped that first item and *added* len of the
remaining icons.
While converting this to new styles system, skipping of the first style in the
latter iteration was lost.

Attached patch fixes and cleans this up by having just one iteration. len is
set to 0 before it, and all rounds in the iteration can just add to it.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 07 Jun 2014 03:29:23 AM EEST  Name: SdlStylesOnce.patch  Size: 8kB  
By: cazfi

<http://gna.org/bugs/download.php?file_id=20944>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?22148>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to