URL:
<http://gna.org/patch/?4822>
Summary: Use requirements_vector for effects
Project: Freeciv
Submitted by: persia
Submitted on: Thu 19 Jun 2014 04:57:17 AM JST
Category: general
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: persia
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.6
_______________________________________________________
Details:
A first pass at consolidating requirements processing: the attached patch
converts all uses of requirements lists to requirements vectors, and replaces
some of the most obvious cases of duplication (or generalises things
previously specific).
This isn't a candidate for application soon: the current draft depends on
posted candidate patches for patch #4679, patch #4797, and patch #4813, and
has received insufficient testing.
I'm not precisely sure what I've done wrong, but the calls to
requirement_fulfilled_by_unit_class() in daieffects.c were complaining about
const values in a way that was unexpectedly different than the use of
requirement_fulfilled_by_unit_type() in helpdata.c. If someone understands
this, and can suggest the right solution, I'd appreciate the assistance.
Any suggestions for other obvious consolidation that sensibly belongs here
welcome.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Thu 19 Jun 2014 04:57:17 AM JST Name:
use-requirements-vector-for-effects-draft.patch Size: 25kB By: persia
<http://gna.org/patch/download.php?file_id=21077>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?4822>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
