Update of bug #22271 (project freeciv):

                  Status:                    None => Confirmed              
                 Release:                         => 2.2.7, 2.4.2           
         Planned Release:                         => 2.4.3, 2.5.0, 2.6.0    

    _______________________________________________________

Follow-up Comment #3:

Confirmed. Root cause is that pplayer->server.capital isn't reset to false
when the player's last city is removed, so build_free_small_wonders() isn't
invoked.

In contrast, in the more usual case where the player's capital is taken when
they have other cities, build_free_small_wonders() puts Palace etc in another
city (iff savepalace is set).

I think it's clear that Palace and other saveable small wonders should be
rebuilt after a player drops to 0 cities iff savepalace is set. However, what
about other corners?
* city_build_free_buildings() builds global and national free buildings, not
all of which may be saveable. Should they all be rebuilt in the 'second first
city'?
* What about saveable buildings iff savepalace==false?

Options:
0 All initial buildings are built in the 'second first city', regardless of
whether they're saveable. (Could lead to perverse incentive to lose last city
when well into game, since you get free stuff for going from 0->1 cities?)
0 Only saveable buildings are built the second time round (so if
savepalace==false, you get no Palace).

If (1), then pplayer->server.capital becomes redundant and can always be
replaced with city_list_size(pplayer) > 0.

If (2), we need to track state like pplayer->server.capital, but I'm inclined
to rename it to has_ever_built_city or something, since it's not necessarily
related to EFT_CAPITAL_CITY.

I'm leaning to (2).

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?22271>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to