Update of patch #5487 (project freeciv):
Status: None => Ready For Test
Planned Release: => 2.5.0, 2.6.0
_______________________________________________________
Follow-up Comment #1:
Attached is patch made out of your changes (for reference) and the version "2"
that I've made, and consider commit-candidate.
> Force the use of nationset = all.
This is against the reasons nationsets functionality was added in the first
place, and the code should work out restrictions of the limited nationset when
possible. With some earlier scenario change we decided to use default
nationset by default. I reverted this change from my version of the patch so
less controversial parts can go forward -> submit patch for this to a new
ticket if you want to push it.
- Originally one of the scenarios had "gamestart_valid=FALSE" and another
"gamestart_valid=TRUE". You had made them both FALSE. I changed them both to
TRUE.
> I reduced the settings to the minimum (that seems to work with v2.5), so it
loads the defaults from the ruleset.
When I converted scenarios to 2.5 format, I thought that any settings with
non-default values were there on purpose. I left all of your changes from
custom value to default value there, though.
In fact, we probably have a regression compared to freeciv-2.2 here. Now that
scenario loading resets settings there's no way to set settings that cannot be
changed after game start (scenario loading counts as one) before, either.
(file #23075, file #23076)
_______________________________________________________
Additional Item Attachment:
File name: EarthMod.patch Size:6 KB
File name: EarthMod-2.patch Size:6 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5487>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
