Follow-up Comment #3, patch #5546 (project freeciv):
>> Since I got no feedback in 48 hours
> It's weekend, no kidding :D
Just couldn't wait to write more code...
> help_uclass_max_values - cannot be in helpdata.c or must be sent as
different patch to common code. Best way could be just some function which
will search max value on demand.
Ok, so if I think other clients will want to use it, I need a separate patch.
Makes sense. So let's keep it private to the Qt client, and make it public
if/when another client uses it.
> - cruise missile and nuke are defense are showed wrong
It's the (undocumented) indeterminate state of QProgressBar when both min =
max = 0. Will take me ~10 min to fix, incl. time to start KDevelop, compile
and test. Not tonight, thought.
> - unit icon on right looks bad, on left would be much better
I agree, it looks bad. Initially I put it on the left, but then I realized the
title was moving from left to right while browsing. It was annoying, because
the eye didn't know where to look for it. Having the title always left-aligned
is better.
The best way out of it would be putting the icon above properties (so the
title wouldn't move at all. See attached screenshot of a Designer draft.
> that horizontal layout looks uglier than gtk, there is just too much wasted
space below properties
> ...
> Overall - its ugly. Why not to make it like in gtk2 ?
- On today's wide screens, vertical space is much more important than
horizontal. A maximized Gtk manual wastes a lot of horizontal space.
- In the Gtk dialog, it is difficult to track which value corresponds to which
label (because they are not properly aligned). The problem is even bigger when
maximized.
- (Using a custom color is problematic, because users can have different
palettes. This is a no-go for me.) Not sure if you wish me to do that.
- At the default Gtk size (and with icon in the sidebar), my layout displays
just as much text. And no, I didn't cheat with fonts ;)
- Text layout issues are caused by the (mis)use of characters to layout text.
Would be prettier if converted to HTML (we could use a more readable
proportional font, add links, ...). Doing this is one of my goals.
== Numbers
On my 1280x1024 display, my layout (maximized) wastes ~170,000 sq.px, while
Gtk wastes ~130,000 sq.px. On a 1280x800 display however, my layout would
waste only 90,000 sq.px (Gtk remains obviously the same).
(file #23189)
_______________________________________________________
Additional Item Attachment:
File name: manual-icon-on-left.png Size:49 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5546>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
